Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions in the docs to enable Jupytext extension in Jupyter Lab #304

Merged
merged 3 commits into from
Sep 1, 2019
Merged

add instructions in the docs to enable Jupytext extension in Jupyter Lab #304

merged 3 commits into from
Sep 1, 2019

Conversation

augusto-herrmann
Copy link

Improve the README.md documentation installation instructions in order to avoid the problem reported in #298.

@mwouts
Copy link
Owner

mwouts commented Jul 22, 2019

Thank you @augusto-herrmann . Sure we should add something along these lines. Also, I may move that comment upwards as actually it is common to both Jupyter notebook and Jupyter Lab.

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #304 into master will decrease coverage by 1.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage    99.2%   97.94%   -1.27%     
==========================================
  Files          70       70              
  Lines        6701     6533     -168     
==========================================
- Hits         6648     6399     -249     
- Misses         53      134      +81
Impacted Files Coverage Δ
tests/test_read_simple_pandoc.py 44.82% <0%> (-55.18%) ⬇️
jupytext/pandoc.py 43.75% <0%> (-52.09%) ⬇️
jupytext/jupytext.py 95.45% <0%> (-4.55%) ⬇️
jupytext/kernels.py 88% <0%> (-4%) ⬇️
tests/test_cli.py 97.61% <0%> (-2.39%) ⬇️
tests/test_mirror.py 98.64% <0%> (-1.36%) ⬇️
tests/test_contentsmanager.py 98.78% <0%> (-1.22%) ⬇️
jupytext/formats.py 98.21% <0%> (-0.72%) ⬇️
jupytext/cell_reader.py 96.57% <0%> (-0.41%) ⬇️
tests/test_pep8.py 98.36% <0%> (-0.03%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799ea65...eac55dc. Read the comment docs.

@mwouts
Copy link
Owner

mwouts commented Jul 24, 2019

@augusto-herrmann I am sorry I can't find the time for merging this - do you mind if I do that in a few weeks time? I think it's worth mentioning the server extension but in most configurations the user does not need to know about it: it's on by default, and all it does it to switch the contents manager to Jupytext's one, which can also be achieved manually following the intruction after

If you don't have the notebook icon on text documents after a fresh restart of your Jupyter server, install the contents manager manually

@augusto-herrmann
Copy link
Author

Sure, I don't mind it at all! :)
I'm just trying to help with the documentation a bit.

@mwouts mwouts added this to the 1.2.2 milestone Aug 30, 2019
@mwouts mwouts merged commit 2883f23 into mwouts:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants